Gracefully fail if the spec is not a map
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
force-pushed
the
julienduchesne/support-spec-json
branch
from
0bfcc5c
to
427008c
Compare
julienduchesne
changed the base branch from
main
to
julienduchesne/test-diff-auth
julienduchesne
changed the title
specspec is not a map
julienduchesne
force-pushed
the
julienduchesne/support-spec-json
branch
from
427008c
to
caff9b7
Compare
malcolmholmes
approved these changes
Feb 5, 2024
Closes #208 The issue mentions that we should fail gracefully, but actually accepting a JSON spec seems like a good option to me
julienduchesne
force-pushed
the
julienduchesne/support-spec-json
branch
from
caff9b7
to
5992c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #325 (I needed the
ExpectedLogsContainutil)Closes #208
Currently, it panics when the
Resourcestruct tries to interact with the spec as if it were a map. We should make sure that the spec actually is a map when we're casting as aResource