Add config "get" and "path" subcommands #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get: Allows quickly getting the current config without going into the YAML settings file - path: Allows actually finding the current config file. Had trouble finding the `/Users/julienduchesne/Library/Application Support/grizzly/settings.yaml` on my machine. This helps While implementing the `config path` function, I noticed that the config logic was a bit weird. While grizzly was possibly reading (through viper) the config file from the workdir, it was writing back to the system config. Is this expected? By using `viper.ConfigFileUsed()`, we write back to the file we're reading the config from
julienduchesne
force-pushed
the
julienduchesne/add-config-get
branch
from
c99f8e6
to
1fdbe6d
Compare
malcolmholmes
approved these changes
Feb 2, 2024
| "sort" | ||
| "strings" | ||
|
|
||
| "github.com/kirsle/configdir" | ||
| "github.com/spf13/viper" | ||
| "gopkg.in/yaml.v3" |
There was a problem hiding this comment.
We use github.com/goccy/go-yaml not this one in Grizzly.
There was a problem hiding this comment.
hmm, it's not in the go.mod file
There was a problem hiding this comment.
Ahh right, that's in an unmerged branch. Ignore this comment then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #315
/Users/julienduchesne/Library/Application Support/grizzly/settings.yamlon my machine. This helpsWhile implementing the
config pathfunction, I noticed that the config logic was a bit weird. While grizzly was possibly reading (through viper) the config file from the workdir, it was writing back to the system config. Is this expected? By usingviper.ConfigFileUsed(), we write back to the file we're reading the config from