Establish multiple providers #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmholmes
force-pushed
the
malcolmholmes/avoid-current-context-calls
branch
from
38f7cc1
to
fd9a23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grizzly currently has three "endpoints" in one provider: Grafana, Cortex/Mimir and Synthetic Monitoring. Each of these
has its own authentication and configuration. Really, they should be separate providers.
This PR resolves that.
Also, whilst in previous PRs we have removed some use of globals, still various places can call
config.CurrentContext()to pull in config, anywhere in the code.
This PR prevents this happening. It makes sure that providers have their configuration injected in at creation so that they
don't need to pull it in via global functions.