-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mimir-distributed] Add support for the query-frontend results cache #1411
Conversation
Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, I think we need to update the small, large, capped-small, capped-large yamls as well and decide what defaults to use. Technically this is backwards compatible, however if we enable it by default then we should mention something about the increased resource use in the CHANGELOG.
- Also note the increased resource usage in the CHANGELOG. Signed-off-by: Patrick Oyarzun <patrick.oyarzun@grafana.com>
@krajorama Thanks for the feedback. I updated the example values files. I chose 4 replicas for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closing this PR to migrate it to https://github.com/grafana/mimir |
Fixes #1403
Tested locally that the results cache is used for subsequent requests for the same data.
Note
fetched_chunk_bytes
, etc are0
, and response_time is sub 10ms.Also tested upgrade from previous chart and enabling / disabling the results cache.
Signed-off-by: Patrick Oyarzun patrick.oyarzun@grafana.com