Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promtail] Allow setting labels and annotations in secret #2030

Merged
merged 3 commits into from
Dec 1, 2022
Merged

[promtail] Allow setting labels and annotations in secret #2030

merged 3 commits into from
Dec 1, 2022

Conversation

zehenrique
Copy link
Contributor

@zehenrique zehenrique commented Nov 30, 2022

Resolves #699

@zanhsieh
Copy link
Collaborator

zanhsieh commented Dec 1, 2022

@zehenrique
Thank you for the contribution. Could you fix the lint error as below?

@zehenrique
Copy link
Contributor Author

hey @zanhsieh. fixed. thanks

Signed-off-by: José Magalhães <zehenrique@users.noreply.github.com>
Signed-off-by: José Magalhães <zehenrique@users.noreply.github.com>
Signed-off-by: José Magalhães <zehenrique@users.noreply.github.com>
@zanhsieh zanhsieh merged commit 433b7f9 into grafana:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[promtail] Allow setting annotations in configuration secret
2 participants