Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query for last values outside time range #147

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

toddtreece
Copy link
Member

@toddtreece toddtreece commented Nov 28, 2022

Fixes #139.

This requires the changes in grafana/grafana#59444

example

The is the same query in Grafana 9.3.0 (without the changes in grafana/grafana#59444)
image

@toddtreece toddtreece requested review from ryantxu and a team November 28, 2022 21:44
@toddtreece toddtreece marked this pull request as draft November 28, 2022 21:44
@toddtreece toddtreece force-pushed the toddtreece/add-next-observation branch from a78e9a7 to 42e88d2 Compare November 29, 2022 20:09
@toddtreece toddtreece force-pushed the toddtreece/add-next-observation branch from 42e88d2 to deefe3f Compare November 29, 2022 20:10
@toddtreece toddtreece marked this pull request as ready for review November 29, 2022 20:30
@toddtreece toddtreece self-assigned this Nov 29, 2022
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 looks great -- thanks

@toddtreece toddtreece merged commit 37f5d37 into main Nov 30, 2022
@toddtreece toddtreece deleted the toddtreece/add-next-observation branch November 30, 2022 19:35
@kkmeghan
Copy link

kkmeghan commented Dec 2, 2022

@toddtreece Which version this be available and when ?

@taleena
Copy link
Collaborator

taleena commented Dec 2, 2022

@toddtreece Correct me if I'm wrong, but @kkmeghan should be able to consume the changes which are now all merged (as mentioned here), and use the latest SiteWise release to test this out.

@toddtreece
Copy link
Member Author

@taleena @kkmeghan this is available in 1.5.0 of the sitewise plugin. it will require using the grafana/grafana:main docker image, or building grafana locally since it's dependent on changes in grafana that have not been released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to fetch query data: no aggregation values found for query
4 participants