Revert "Replace deprecated setVariableQueryEditor with CustomVariableSupport" #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
fridgepoet and
kevinwcyu
and removed request for
a team
fridgepoet
approved these changes
Oct 10, 2023
idastambuk
force-pushed
the
revert-184-variable-editor
branch
from
81d3a73
to
b2fc1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #184
This fixes #227
The reason for this revert is that we need to use metricFindQuery for query variable support, otherwise the variable object resolves to
{text: "Demo Wind Farm Asset", value "Demo Wind Farm Asset"}, which is not what we want, since when they are selected in dashboards, their IDs are sent in different types of queries and not their names.The only time we would need the names is when the variables are being filtered by regex like here. However, the solution for this in the original commit is just a consequence of the values being the same as names, and not a proper fix.
I will reopen the original ticket, since we will need to reimplement custom variable support.