Variables: add variable support #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bymattoa -- most of this PR is formatting changes due to an upgrade in prettier :( |
ryantxu
commented
Jan 25, 2021
| return this.datasource.query(request).pipe( | ||
| mergeMap((rsp) => { | ||
| const assets = new DataFrameView<HierarchyInfo>(rsp.data[0]); | ||
| const data: MetricFindValue[] = assets.map((a) => ({ |
There was a problem hiding this comment.
The default behavior just uses the string values as the variables... BUT for this, I assume we actually want the ids as the template value and the name as what is displayed
There was a problem hiding this comment.
We will also need to fetch property IDs. (See thread in conversation)
bymattoa
reviewed
Feb 1, 2021
|
This now uses the "Describe Asset" query to pick properties:
|
|
NOTE: the "Explore" button does not work -- need to investigate why, but It does not look like an easy easy fix 😢 should we merge without that fix first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for query variables. Related to #113