Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses strings.Builder instead of []byte in iter.ReadString #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Uses strings.Builder instead of []byte in iter.ReadString #1

wants to merge 1 commit into from

Conversation

cyriltovena
Copy link

This is to avoid allocations, also fixes tests still not working with go1.15.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

@cyriltovena
Uses strings.Builder instead of []byte in iter.ReadString
1244aa5 
This is to avoid allocations, also fixes tests still not working with go1.15.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean Awaiting requested review from slim-bean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cyriltovena @CLAassistant