Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self complex scope improvements #25

Merged
merged 2 commits into from
Feb 9, 2022
Merged

self complex scope improvements #25

merged 2 commits into from
Feb 9, 2022

Conversation

julienduchesne
Copy link
Member

Follow-up to #23
See the test file for examples. Fetching self.sub2 and self.test3 now works!

@julienduchesne
Complex self scope improvements
b528d8b 
Follow-up to #23
See the test file for examples. Fetching `self.sub2` and `self.test3` now works!
@julienduchesne julienduchesne changed the title Complex self scope improvements self complex scope improvements Jan 25, 2022
Base automatically changed from julienduchesne/fix-self-scope to main January 27, 2022 11:32
zzehring
zzehring approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks :chefs_kiss:! Really like what you did with the comments in the test jsonnet file. Think when we get together a more comprehensive contributing guide, I'd like to see more of that type of annotation.

@julienduchesne julienduchesne merged commit 4a094f7 into main Feb 9, 2022
@julienduchesne julienduchesne deleted the julienduchesne/more-self-cases branch February 9, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzehring zzehring zzehring approved these changes

@jdbaldry jdbaldry Awaiting requested review from jdbaldry jdbaldry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @zzehring