Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self scope #23

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fix self scope #23

merged 2 commits into from
Jan 27, 2022

Conversation

julienduchesne
Copy link
Member

Fields outside of the scope of self are currently being resolved
See the test for an example
Fixes #2

pkg/position/range.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix on this!

pkg/processing/object.go Outdated Show resolved Hide resolved
pkg/processing/object.go Show resolved Hide resolved
Fields outside of the scope of `self` are currently being resolved
See the test for an example
Fixes #2
@julienduchesne
Copy link
Member Author

@zzehring Addressed your comments!

julienduchesne added a commit that referenced this pull request Jan 25, 2022
Follow-up to #23
See the test file for examples. Fetching `self.sub2` and `self.test3` now works!
Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienduchesne julienduchesne merged commit 546b258 into main Jan 27, 2022
@julienduchesne julienduchesne deleted the julienduchesne/fix-self-scope branch January 27, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition: self shouldn't resolve attributes of an out-of-scope map
2 participants