Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K6_BROWSER_TRACES_METADATA docs #1455

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Add K6_BROWSER_TRACES_METADATA docs #1455

merged 2 commits into from
Dec 21, 2023

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Dec 18, 2023

What?

Adds documentation for the traces metadata env variable, which allows setting extra metadata attributes for the spans generated from the browser module.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/xk6-browser#1104

Adds documentation for the traces metadata env variable, which allows
setting extra metadata attributes for the spans generated from the
browser module.
| K6_BROWSER_HEADLESS | Show browser GUI or not. `true` by default. |
| K6_BROWSER_IGNORE_DEFAULT_ARGS | Ignore any of the [default arguments](#default-arguments) included when launching a browser process. |
| K6_BROWSER_TIMEOUT | Default timeout to use for various actions and navigation. `'30s'` if not set. |
| K6_BROWSER_TRACES_METADATA | Sets additional _key-value_ metadata that will be included as attributes in every span generated from browser module traces. Example: `K6_BROWSER_TRACES_METADATA=attr1=val1,attr2=val2`. This will only apply if traces generation is enabled by k6 options, see `--traces-output` option [docs](https://grafana.com/docs/k6/<K6_VERSION>/using-k6/k6-options/reference#traces-output). |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some other changes were applied automatically when committing, but this is the main change.

@ka3de ka3de marked this pull request as ready for review December 18, 2023 11:08
@ka3de ka3de added the Area: browser The browser module label Dec 18, 2023
@ka3de ka3de self-assigned this Dec 18, 2023
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small suggestion to the description, but LGTM! 🙇

Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
@ka3de ka3de merged commit 40eae76 into main Dec 21, 2023
6 checks passed
@ka3de ka3de deleted the add/browser-traces-meta branch December 21, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants