Inconsistent Docker version tags

[knittl]

Brief summary

Kudos on the 0.40.0 release! 🎉

I'm not sure if this even qualifies a bug, but the Docker version tag format hat changed from grafana/k6:0.39.0 to grafana/k6:v0.40.0 (note the v).

It took me a few minutes to find out why docker pull would not fetch the latest version. Was it intentional? Could be related to #2676

Nothing serious, just wanted to mention it.

k6 version

v0.40.0

OS

n/a

Docker version and image (if applicable)

v0.40.0

Steps to reproduce the problem

1. docker pull grafana/k6:0.39.0 works
2. docker pull grafana/k6:0.40.0 does not work
3. docker pull grafana/k6:v0.40.0 works

Expected behaviour

I can pull 0.40.0 the same way I pulled the previous versions :)

Actual behaviour

Docker tag of 0.40.0 is actually v0.40.0

[na--]

Ah... I hate CI changes 😭 Thanks for letting us know, we will fix this manually for 0.40.0 / v0.40.0 and fix the CI so it doesn't happen in the future.

[na--]

The manually re-tagged and pushed loadimpact/k6:v0.40.0 as loadimpact/k6:0.40.0 and the grafana/k6:0.40.0 tag was fixed with this one-off commit: c90346a

I'll make a proper fix for the bug I introduced in #2591. And it only applied for the docker container registry images, the ghcr.io image was correctly pushed as 0.40.0... 😭

I think the problem was that I didn't export this variable (or repeat the same string manipulation in the subsequent step for Docker Hub):

k6/.github/workflows/build.yml

Line 170 in 63054ef

VERSION="${VERSION#v}"

[na--]

#2678 is the PR that hopefully fixes this... 🤞

[knittl]

Awesome, thanks for the quick resolution! ❤️