Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twirp suport #2261

Closed
wants to merge 1 commit into from
Closed

Twirp suport #2261

wants to merge 1 commit into from

Conversation

ishumilova
Copy link

@ishumilova ishumilova commented Nov 23, 2021

Todo:

  • Protobuf endpoints support
  • JSON endpoints support
  • Tests

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ishumilova ishumilova changed the title temp: twirp protobuf suport Twirp suport Nov 23, 2021
@mstoykov
Copy link
Contributor

mstoykov commented Nov 25, 2021

Hi, @ishumilova I see that you are still working on this PR, but I just wanted to note that we are unlikely to add support for this to k6.

Many people have wanted support for different protocols over the years and we likely will add a lot more to the core of k6, but the current proposed solution for people who want to use k6 and are willing to write the code is to make an extension. This lets you do your work and use k6 but doesn't require us to review your code and you to make it compliant with our requirements or to be building functionality that we want in k6 :).

There is some small amount of documentation (that as mentioned there can get outdated) that can help you but in reality, it's the same as having to develop it for the core k6 it just lives in its own repo and gets build with xk6.

Sorry for the inconvenience, good luck and I will be glad to see your extension in the list of extensions.

@mstoykov mstoykov closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants