Small js refactor #2373
Merged
Small js refactor #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
force-pushed
the
smallJSRefactor
branch
from
5c60e21
to
56b3486
Compare
There really isn't a reason why it should use the context - if the context is done the whole runtime is interrupted so it won't even get to that code
mstoykov
force-pushed
the
smallJSRefactor
branch
from
56b3486
to
8e9ecd0
Compare
na--
approved these changes
Feb 4, 2022
codebien
reviewed
Feb 4, 2022
| ctxPtr := new(context.Context) | ||
|
|
||
| func (b *Bundle) Instantiate( | ||
| logger logrus.FieldLogger, vuID uint64, vuImpl *moduleVUImpl, |
There was a problem hiding this comment.
Suggested change
| logger logrus.FieldLogger, vuID uint64, vuImpl *moduleVUImpl, | |
| logger logrus.FieldLogger, vuID uint64, vuImpl *moduleVUImpl, |
Could now we have vuID as part of vuImpl?
There was a problem hiding this comment.
probably in another PR see #2373 (comment)
Comment on lines
258
to
+260
| // Instantiate the bundle into a new VM using a bound init context. This uses a context with a | ||
| // runtime, but no state, to allow module-provided types to function within the init context. | ||
| rt := goja.New() | ||
| init := newBoundInitContext(b.BaseInitContext, ctxPtr, rt) | ||
| if err := b.instantiate(logger, rt, init, vuID); err != nil { | ||
| vuImpl.runtime = goja.New() |
There was a problem hiding this comment.
Could we now directly inject a vuImpl with an initialized runtime so we can maintain the initialization in one central place? (e.g. runner.newVU)
There was a problem hiding this comment.
in a followign PR :P There are in practice a lot more changes, I just really needed moduleVUImpl to be part of VU and everything else was gravy
codebien
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit.
The idea(s) of this PR are to move away from common.Bind usage and to facilitate some changes I need for #2228 without making that PR huge