Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.20 #2920

Merged
merged 2 commits into from Feb 21, 2023
Merged

Bump Go version to 1.20 #2920

merged 2 commits into from Feb 21, 2023

Conversation

codebien
Copy link
Collaborator

No description provided.

@codebien codebien added this to the v0.44.0 milestone Feb 21, 2023
@codebien codebien self-assigned this Feb 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2920 (1060e84) into master (8601303) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1060e84 differs from pull request most recent head 6679289. Consider uploading reports for the commit 6679289 to get more accurate results

@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
+ Coverage   76.92%   76.93%   +0.01%     
==========================================
  Files         225      225              
  Lines       16873    16873              
==========================================
+ Hits        12979    12981       +2     
  Misses       3062     3062              
+ Partials      832      830       -2     
Flag Coverage Δ
ubuntu 76.83% <ø> (-0.02%) ⬇️
windows 76.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metrics/value_type.go 62.50% <0.00%> (-6.25%) ⬇️
metrics/metric_type.go 78.94% <0.00%> (-3.51%) ⬇️
js/initcontext.go 88.18% <0.00%> (+1.57%) ⬆️
api/v1/metric.go 81.81% <0.00%> (+18.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codebien codebien marked this pull request as ready for review February 21, 2023 09:33
@codebien codebien requested review from na-- and a team and removed request for oleiade February 21, 2023 09:34
imiric
imiric previously approved these changes Feb 21, 2023
olegbespalov
olegbespalov previously approved these changes Feb 21, 2023
@olegbespalov
Copy link
Collaborator

Probably it makes sense to change the version in Dockerfile, but it could a separated PR

Copy link
Collaborator

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump 1.18.x in the test.yml to 1.19.x as well

And Maybe even look into bumping golangci-lint as we are stuck at 1.18.x for it as well

mstoykov
mstoykov previously approved these changes Feb 21, 2023
@codebien
Copy link
Collaborator Author

And Maybe even look into bumping golangci-lint as we are stuck at 1.18.x for it as well

I'm already on it but I would prefer to open a dedicated PR

@codebien codebien merged commit b86fc5c into master Feb 21, 2023
@codebien codebien deleted the go-1-20 branch February 21, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants