Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Bump go version for test-current-cov #2922

Closed
wants to merge 2 commits into from

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Feb 21, 2023

Unfortunately I missed it during #2920. Fixing.

@codebien codebien added this to the v0.44.0 milestone Feb 21, 2023
@codebien codebien self-assigned this Feb 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #2922 (53b84b0) into master (4463298) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 53b84b0 differs from pull request most recent head 698fc0d. Consider uploading reports for the commit 698fc0d to get more accurate results

@@           Coverage Diff           @@
##           master    #2922   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files         225      225           
  Lines       16893    16895    +2     
=======================================
+ Hits        13001    13004    +3     
+ Misses       3061     3060    -1     
  Partials      831      831           
Flag Coverage Δ
ubuntu 76.86% <50.00%> (-0.03%) ⬇️
windows 76.75% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/fsext/walk.go 47.36% <75.00%> (ø)
js/common/initenv.go 100.00% <100.00%> (ø)
api/v1/metric.go 63.63% <0.00%> (-4.55%) ⬇️
metrics/value_type.go 68.75% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codebien codebien force-pushed the bump-go-current-cov branch 2 times, most recently from 2c29c0c to 53887ac Compare February 25, 2023 16:45
@codebien
Copy link
Collaborator Author

codebien commented Mar 1, 2023

Closing in favour of #2928

@codebien codebien closed this Mar 1, 2023
@codebien codebien deleted the bump-go-current-cov branch May 12, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants