Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate prepending https:// in tries to load modules #3288

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Aug 18, 2023

What?

Change the message to make it explicit prepending https:// to module specifiers is deprecated.

Why?

It was there only as that was how remote modules were only loadable before it was changed that full URLs are supported.

As there have been 4 years and it seems like nobody is using this anymore, removing it removes some guessing and warning messages that mostly confuse users.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Part of #3287

Changelog

breaking: deprecate k6 figuring out if an import specifier is a URL by trying to resolve it by prepending https:// in case it can't figure it out. To be fully removed v0.48.0.

@mstoykov mstoykov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Aug 18, 2023
@mstoykov mstoykov added this to the v0.47.0 milestone Aug 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3288 (3d276b0) into master (420767c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 3d276b0 differs from pull request most recent head 43df59a. Consider uploading reports for the commit 43df59a to get more accurate results

@@            Coverage Diff             @@
##           master    #3288      +/-   ##
==========================================
- Coverage   73.21%   73.16%   -0.06%     
==========================================
  Files         258      256       -2     
  Lines       19884    19879       -5     
==========================================
- Hits        14559    14544      -15     
- Misses       4402     4407       +5     
- Partials      923      928       +5     
Flag Coverage Δ
ubuntu 73.16% <100.00%> (+0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
loader/loader.go 83.56% <100.00%> (ø)

... and 9 files with indirect coverage changes

@mstoykov mstoykov merged commit 4ad625c into master Aug 18, 2023
21 checks passed
@mstoykov mstoykov deleted the deprecateGuessingRemoteModules branch August 18, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants