Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the tests reference in the all rule of the Makefile #3410

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

flyck
Copy link
Contributor

@flyck flyck commented Oct 21, 2023

What?

Tiny fix for the makefile.

Current behavior:

❯ make all
cleaning
make: *** No rule to make target `test', needed by `all'.  Stop.

New behavior: Runs all commands

Why?

Make all should succeed

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2023

CLA assistant check
All committers have signed the CLA.

@mstoykov
Copy link
Contributor

Thanks for this catch and fix @flyck 🙇

Unfortunately we won't be able to merge this without you signing the cla :(.

I will wait for you for a few days, but if it is not possible I guess we will do this change ourself, sorry for the inconvenience :(

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the CLA will be signed

@flyck
Copy link
Contributor Author

flyck commented Oct 23, 2023

Thanks guys, turns out I had the wrong email in the commit which is why the CLA was not showing as signed. Just force-pushed that author change ☝🏻

@mstoykov mstoykov merged commit 0f204b9 into grafana:master Oct 25, 2023
15 of 21 checks passed
@olegbespalov olegbespalov added this to the v0.48.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants