Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a custom node group label #5

Closed
tavisto opened this issue Mar 3, 2023 · 2 comments · Fixed by #6
Closed

Allow a custom node group label #5

tavisto opened this issue Mar 3, 2023 · 2 comments · Fixed by #6
Labels
enhancement New feature or request

Comments

@tavisto
Copy link
Contributor

tavisto commented Mar 3, 2023

In order to use this with other types of clusters, or cloud clusters that have a custom label defined. There should be a flag that you can pass a custom label to the command for grouping nodes into pools.
@inkel inkel added the enhancement New feature or request label Mar 3, 2023
@inkel inkel linked a pull request Mar 3, 2023 that will close this issue
Added the ability to pass a custom node label. Resolves #5 #6
Merged
@inkel
Copy link
Collaborator

inkel commented Mar 3, 2023

I LOVE this idea! Let me review your PR, thanks!

@inkel inkel closed this as completed in #6 Mar 3, 2023
inkel added a commit that referenced this issue Mar 3, 2023
@inkel
Merge pull request #6 from tavisto/main
8a913e0 
Added the ability to pass a custom node label. Resolves #5
@inkel
Copy link
Collaborator

inkel commented Mar 3, 2023

Version v0.0.3 of the plugin has just been released, which includes your changes. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added the ability to pass a custom node label. Resolves #5 tavisto/kubectl-nodepools
2 participants
@tavisto @inkel