Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to pass a custom node label. Resolves #5 #6

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Added the ability to pass a custom node label. Resolves #5 #6

merged 1 commit into from
Mar 3, 2023

Conversation

tavisto
Copy link
Contributor

@tavisto tavisto commented Mar 3, 2023

I wanted to use this tool on both vanilla kops clusters, as well as some custom ones.
I have added the ability to pass a custom label to allow any custom label to group nodes.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@inkel inkel linked an issue Mar 3, 2023 that may be closed by this pull request
Allow a custom node group label #5
Closed
inkel
inkel reviewed Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I've left a couple of comments, but the actual implementation looks great, simple and elegant.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
inkel
inkel approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@inkel inkel merged commit 8a913e0 into grafana:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkel inkel inkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow a custom node group label
3 participants
@tavisto @CLAassistant @inkel