Add LogQL formatter #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this I would:
|
matyax
reviewed
Jul 14, 2023
matyax
reviewed
Jul 14, 2023
| expect(formatLokiQuery(`{label=""} | label=10s`)).toBe(`{label=""}\n | label=10s`); | ||
| expect(formatLokiQuery(`{label=""} | label=1GB`)).toBe(`{label=""}\n | label=1GB`); | ||
| expect(formatLokiQuery(`{label=""} | label=42`)).toBe(`{label=""}\n | label=42`); | ||
| // expect(formatLokiQuery(`{label=""} | labelA="A" and labelB="B"`)).toBe( |
There was a problem hiding this comment.
these tests are commented out because they are failing.
these fixes are on my todo.
matyax
reviewed
Jul 14, 2023
|
@matyax besides the few bugs that are on the radar i believe this is ready so we can get an experimental version running in grafana 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how to test this pr:
in grafana/lezer-logql:
in grafana/grafana
gareth/prettify-querylokiFormatQuery! grafana should now be using this build of lezer, try formatting some queries.