Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: migrate from Mocha to Jest #32

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Jul 11, 2023

Not only Jest is currently the standard for testing libraries, and what we use in Grafana, but also all the tests for the LogQL formatter were written in it. So before progressing with #29 we need to add the test cases for it.

This PR migrates from Mocha to Jest, adding the necessary configuration to make it work.

@matyax matyax requested review from gwdawson, svennergr and ivanahuckova and removed request for gwdawson and svennergr July 11, 2023 10:39
Copy link
Member

@gwdawson gwdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment, otherwise LGTM!

package.json Show resolved Hide resolved
@matyax matyax merged commit 9b63ea1 into main Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants