Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular dependencies #39

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix circular dependencies #39

merged 1 commit into from
Jul 20, 2023

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Jul 18, 2023 •
edited

Before:

src/parser.js, src/exports.js → ./dist/index.cjs, ./dist/index.es.js...
(!) Circular dependency
src/formatter/formatter.js -> src/formatter/metrics.js -> src/formatter/formatter.js
created ./dist/index.cjs, ./dist/index.es.js in 80ms

After:

src/parser.js, src/exports.js → ./dist/index.cjs, ./dist/index.es.js...
created ./dist/index.cjs, ./dist/index.es.js in 77ms

@gwdawson gwdawson requested a review from matyax July 18, 2023 13:34
@gwdawson gwdawson self-assigned this Jul 18, 2023
@gwdawson gwdawson mentioned this pull request Jul 18, 2023
Merged
matyax
matyax approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gwdawson gwdawson merged commit 9d4b95f into main Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@gwdawson gwdawson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwdawson @matyax