Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix husky error when installing lezer-logql as dependency #40

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

gwdawson
Copy link
Member

we only want to merge this after #39 so that fix is also included in the build

currently if you try to install @grafana/lezer-logql@0.1.7 you will receive an error. this is caused by using "postinstall" instead of "prepare".
One word of caution, use the "postinstall" hook only if you're not publishing your project on npm, else your users will get errors when trying to install your module. typicode/husky#227 (comment)

@gwdawson gwdawson self-assigned this Jul 18, 2023
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@gwdawson gwdawson merged commit ec733dc into main Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants