Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating prometheus/common to v0.24.0 #5

Closed
wants to merge 1 commit into from
Closed

Conversation

hef
Copy link

@hef hef commented May 11, 2021

No description provided.

@hef
Copy link
Author

hef commented May 11, 2021

I added config.WithKeepAlivesDisabled(), config.WithHTTP2Disabled() to match existing options, but do we actually want those options?

@jpinsonneau
Copy link

could we merge this ? v0.31.1 is also available 👍

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hef
Copy link
Author

hef commented Jun 15, 2022

That CLA link takes me to a page that says:

There is no CLA to sign for grafana/loki-client-go
(could not find linked item for owner grafana and repo loki-client-go)

@slim-bean
Copy link
Contributor

Closed in favor of #6

@slim-bean slim-bean closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants