Upgrade Prometheus Dependency #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this library with versions of Prometheus newer than when the pkg/ directory was removed is failing. Upgrade the Prometheus dependency to the most recent release, and people who still need the older dependency can use an older version.
csmarchbanks
commented
Apr 28, 2022
| @@ -162,7 +162,7 @@ func NewWithLogger(cfg Config, logger log.Logger) (*Client, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| c.client, err = config.NewClientFromConfig(cfg.Client, "promtail", false, false) | |||
| c.client, err = config.NewClientFromConfig(cfg.Client, "promtail", config.WithHTTP2Disabled()) | |||
There was a problem hiding this comment.
I left HTTP2 disabled as that was the previous behavior, but in newer versions of Go could this be enabled again?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library with versions of Prometheus newer than when the pkg/
directory was removed is failing. Upgrade the Prometheus dependency to
the most recent release, and people who still need the older dependency
can use an older version.