Skip to content

Commit

Permalink
Restoring metrics removed by #6957, simplifying implementation (#6962)
Browse files Browse the repository at this point in the history
Adding all available metrics from Go

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
  • Loading branch information
Danny Kopping committed Aug 24, 2022
1 parent 2321da4 commit 449dd81
Showing 1 changed file with 7 additions and 16 deletions.
23 changes: 7 additions & 16 deletions pkg/loki/modules.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,23 +97,14 @@ const (
UsageReport string = "usage-report"
)

func (t *Loki) initRegisterer() prometheus.Registerer {
registry := prometheus.NewRegistry()
registry.MustRegister(version.NewCollector("loki"))
registry.MustRegister(collectors.NewGoCollector(
collectors.WithGoCollectorRuntimeMetrics(collectors.MetricsScheduler),
))

// override default registerer & gatherer since we refer to these global variables in several places
// TODO: refactor the rest of the codebase to decouple from these global variables
prometheus.DefaultRegisterer = registry
prometheus.DefaultGatherer = registry

return registry
}

func (t *Loki) initServer() (services.Service, error) {
t.initRegisterer()
prometheus.MustRegister(version.NewCollector("loki"))
// unregister default go collector
prometheus.Unregister(collectors.NewGoCollector())
// register collector with additional metrics
prometheus.MustRegister(collectors.NewGoCollector(
collectors.WithGoCollectorRuntimeMetrics(collectors.MetricsAll),
))

// Loki handles signals on its own.
DisableSignalHandling(&t.Cfg.Server)
Expand Down

0 comments on commit 449dd81

Please sign in to comment.