Upgrade prometheus/client_golang and reconfigure to restore go_sched.* metrics
#6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These metrics were removed unintentionally in grafana#6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
force-pushed
the
dannykopping/restore-go-sched-metrics
branch
from
9320d17
to
47ba154
Compare
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0.1% |
dannykopping
changed the title
go_sched.* metricsgo_sched.* metrics
dannykopping
changed the title
go_sched.* metricsgo_sched.* metrics
MichelHollands
approved these changes
Aug 23, 2022
| @@ -96,8 +97,23 @@ const ( | |||
| UsageReport string = "usage-report" | |||
| ) | |||
|
|
|||
| func (t *Loki) initRegisterer() prometheus.Registerer { | |||
There was a problem hiding this comment.
nit: The name of this function makes it look like there is a module called Registerer.
There was a problem hiding this comment.
That's true, I think I'll leave this for now and refactor it when I get rid of the reliance on the prometheus.DefaultXXX references
|
@DylanGuedes raised a point in Slack: will the upgrade of prometheus/common@v0.35.0...v0.37.0 The diff doesn't seem to show anything too scary, and unfortunately there is no changelog in |
dannykopping
pushed a commit
that referenced
this pull request
Aug 23, 2022
….*` metrics (#6957) * Upgrading prometheus/client_golang to restore go_sched.* metrics These metrics were removed unintentionally in #6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Fixing test to match interface correctly Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
pushed a commit
to dannykopping/loki
that referenced
this pull request
Aug 24, 2022
Adding all available metrics from Go Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
4 tasks
dannykopping
pushed a commit
that referenced
this pull request
Aug 24, 2022
Adding all available metrics from Go Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
pushed a commit
that referenced
this pull request
Aug 24, 2022
Adding all available metrics from Go Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
|
@dannykopping Can we consider backporting this to 2.6? My key pain point is: |
dannykopping
added
the
backport release-2.6.x
|
Sure 👍 |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6957-to-release-2.6.x origin/release-2.6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 2321da49b580dd00204fe9f19a0db837af8d19f0
# Push it to GitHub
git push --set-upstream origin backport-6957-to-release-2.6.x
git switch main
# Remove the local backport branch
git branch -D backport-6957-to-release-2.6.xThen, create a pull request where the |
dannykopping
pushed a commit
that referenced
this pull request
Aug 29, 2022
Adding all available metrics from Go Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
….*` metrics (grafana#6957) * Upgrading prometheus/client_golang to restore go_sched.* metrics These metrics were removed unintentionally in grafana#6403 Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Fixing test to match interface correctly Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
…grafana#6962) Adding all available metrics from Go Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
These metrics were removed unintentionally in #6403.
The
go_sched_latencieshistogram is very important for determining pathological scheduler behaviour (I need it to verify the impact of #6954).Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Don't be afraid of the PR size; it's mainly just revendored code.
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md