add tests to the calculateMaxLookBack

Signed-off-by: Ed Welch <edward.welch@grafana.com>
grafana · May 14, 2020 · c15f5a9 · c15f5a9
1 parent e9442ea
commit c15f5a9
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 1 deletion.
diff --git a/pkg/loki/modules.go b/pkg/loki/modules.go
@@ -504,7 +504,7 @@ func activePeriodConfig(cfg chunk.SchemaConfig) chunk.PeriodConfig {
 }
 
 func calculateMaxLookBack(pc chunk.PeriodConfig, maxLookBackConfig, maxChunkAge time.Duration) (time.Duration, error) {
-	if pc.ObjectType != local.FilesystemObjectStoreType && maxLookBackConfig.Milliseconds() != 0 {
+	if pc.ObjectType != local.FilesystemObjectStoreType && maxLookBackConfig.Nanoseconds() != 0 {
 		return 0, errors.New("it is an error to specify a non zero `query_store_max_look_back_period` value when using any object store other than `filesystem`")
 	}
 	// When using shipper, limit max look back for query to MaxChunkAge + upload interval by shipper + 15 mins to query only data whose index is not pushed yet

diff --git a/pkg/loki/modules_test.go b/pkg/loki/modules_test.go
@@ -65,3 +65,78 @@ func TestActiveIndexType(t *testing.T) {
 	assert.Equal(t, cfg.Configs[1], activePeriodConfig(cfg))
 
 }
+
+func Test_calculateMaxLookBack(t *testing.T) {
+	type args struct {
+		pc                chunk.PeriodConfig
+		maxLookBackConfig time.Duration
+		maxChunkAge       time.Duration
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    time.Duration
+		wantErr bool
+	}{
+		{
+			name: "default",
+			args: args{
+				pc: chunk.PeriodConfig{
+					ObjectType: "filesystem",
+				},
+				maxLookBackConfig: 0,
+				maxChunkAge:       1 * time.Hour,
+			},
+			want:    90 * time.Minute,
+			wantErr: false,
+		},
+		{
+			name: "infinite",
+			args: args{
+				pc: chunk.PeriodConfig{
+					ObjectType: "filesystem",
+				},
+				maxLookBackConfig: -1,
+				maxChunkAge:       1 * time.Hour,
+			},
+			want:    -1,
+			wantErr: false,
+		},
+		{
+			name: "invalid store type",
+			args: args{
+				pc: chunk.PeriodConfig{
+					ObjectType: "gcs",
+				},
+				maxLookBackConfig: -1,
+				maxChunkAge:       1 * time.Hour,
+			},
+			want:    0,
+			wantErr: true,
+		},
+		{
+			name: "less than default",
+			args: args{
+				pc: chunk.PeriodConfig{
+					ObjectType: "filesystem",
+				},
+				maxLookBackConfig: 1 * time.Hour,
+				maxChunkAge:       1 * time.Hour,
+			},
+			want:    0,
+			wantErr: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := calculateMaxLookBack(tt.args.pc, tt.args.maxLookBackConfig, tt.args.maxChunkAge)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("calculateMaxLookBack() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("calculateMaxLookBack() got = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}