[docs] Comments and issues on operations/caching page
#9073
Assignees
Labels
good first issue
These are great first issues. If you are looking for a place to start, start here!
help wanted
We would love help on these issues. Please come help us!
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
Comments
chaudum
added
the
type/docs
JStickler
added
the
good first issue
JStickler
added
the
help wanted
8 tasks
JStickler
added a commit
that referenced
this issue
Nov 22, 2023
**What this PR does / why we need it**: There were some typo mistakes that I fixed in the **caching.md** file and it was mentioned in the issue that I have given below. **Which issue(s) this PR fixes**: Fixes [Issue #9073](#9073) **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) Signed-off-by: Bilal Khan <bilalkhanrecovered@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>
8 tasks
grafanabot
pushed a commit
that referenced
this issue
Nov 22, 2023
**What this PR does / why we need it**: There were some typo mistakes that I fixed in the **caching.md** file and it was mentioned in the issue that I have given below. **Which issue(s) this PR fixes**: Fixes [Issue #9073](#9073) **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) Signed-off-by: Bilal Khan <bilalkhanrecovered@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> (cherry picked from commit 13b58af)
JStickler
pushed a commit
that referenced
this issue
Nov 22, 2023
Backport 13b58af from #11214 --- **What this PR does / why we need it**: There were some typo mistakes that I fixed in the **caching.md** file and it was mentioned in the issue that I have given below. **Which issue(s) this PR fixes**: Fixes [Issue #9073](#9073) **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) Co-authored-by: Bilal Khan <64713734+ibilalkayy@users.noreply.github.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this issue
Apr 12, 2024
**What this PR does / why we need it**: There were some typo mistakes that I fixed in the **caching.md** file and it was mentioned in the issue that I have given below. **Which issue(s) this PR fixes**: Fixes [Issue grafana#9073](grafana#9073) **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a) Signed-off-by: Bilal Khan <bilalkhanrecovered@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, I have comments and issues to report on the caching documentation for Loki. It's easier for me to annotate a screenshot of the page, I hope it's okay.
https://grafana.com/docs/loki/latest/operations/caching/
The text was updated successfully, but these errors were encountered: