Fix docs about operations/caching #9718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
type/docs
aroramrinaal
approved these changes
Jun 16, 2023
saeidee
reviewed
Aug 1, 2023
Comment on lines
+95
to
+97
| helm upgrade --install write-cache -n loki bitnami/memcached -f memcached-overides-write.yaml | ||
| helm upgrade --install results-cache -n loki bitnami/memcached -f memcached-overides-results.yaml | ||
| helm upgrade --install index-cache -n loki bitnami/memcached -f memcached-overides-index.yaml |
There was a problem hiding this comment.
Suggested change
| helm upgrade --install write-cache -n loki bitnami/memcached -f memcached-overides-write.yaml | |
| helm upgrade --install results-cache -n loki bitnami/memcached -f memcached-overides-results.yaml | |
| helm upgrade --install index-cache -n loki bitnami/memcached -f memcached-overides-index.yaml | |
| helm upgrade --install write-cache -n loki bitnami/memcached -f memcached-overrides-write.yaml | |
| helm upgrade --install results-cache -n loki bitnami/memcached -f memcached-overrides-results.yaml | |
| helm upgrade --install index-cache -n loki bitnami/memcached -f memcached-overrides-index.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #9073
This documentation update follows recent changes in Loki's caching strategy and the use of Memcached. Reviewers are encouraged to pay special attention to the accuracy and comprehensiveness of the Memcached configuration examples provided.
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR