Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated s3 sse toggle #10377

Merged
merged 7 commits into from Aug 29, 2023
Merged

Remove deprecated s3 sse toggle #10377

merged 7 commits into from Aug 29, 2023

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Aug 29, 2023 •
edited

What this PR does / why we need it:

AWS now defaults to SSE S3 for every bucket. All objects are automatically encrypted at no additional cost. Thus, this change will deprecate the enable toggle from Loki.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@shantanualsi
Remove deprecated s3.sse-encryption
aba8529 
AWS now defaults to SSE S3 for every bucket. All objects are automatically encrypted at no additional cost. Thus, this change will deprecate the enable toggle from Loki.
@shantanualsi
Update changelog and docs after removing s3.sse-encryption
ff086e9
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 29, 2023
@shantanualsi shantanualsi changed the title Cleanup campsite/remove s3 sse toggle Remove deprecated s3 sse toggle Aug 29, 2023
@shantanualsi shantanualsi marked this pull request as ready for review August 29, 2023 09:27
@shantanualsi shantanualsi requested a review from a team as a code owner August 29, 2023 09:27
@chaudum chaudum mentioned this pull request Aug 29, 2023
Merged
7 tasks
chaudum
chaudum approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion for improving the changelog entry, otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@chaudum chaudum enabled auto-merge (squash) August 29, 2023 13:28
@chaudum chaudum merged commit 325c332 into main Aug 29, 2023
7 checks passed
@chaudum chaudum deleted the cleanup-campsite/remove-s3-sse-toggle branch August 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shantanualsi @chaudum