Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Module s3 dependency fix #10557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

aschaber1
Copy link

@aschaber1 aschaber1 commented Sep 12, 2023

What this PR does / why we need it:

  • The module requires a very narrow terraform providers.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@aschaber1 aschaber1 requested a review from a team as a code owner September 12, 2023 21:25
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@aschaber1
Copy link
Author

Rebased the PR after signing the CLA.

@aschaber1
Copy link
Author

Rebased the source branch again, so it is in line with current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants