Increased promtail's backoff settings in prod and improved doc #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to rebase on gomod. Sorry ! EDIT: Nevermind ! the dependency change was done before :) |
pracucci
force-pushed
the
fine-tune-promtail-backoff-settings
branch
from
cf422a7
to
9258525
Compare
|
@cyriltovena I've rebased anyway |
|
@cyriltovena I've seen it's approved since a week. If the reason why it doesn't get merged is the change to |
|
No I was waiting on gomod PR to be fully tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current promtail's backoff configuration starts dropping log entries if the Loki distributor endpoint is unreachable for 3.1s (worst case) - 6.2s (best case). In this PR, I'm proposing to increase the number of retries to 20, which increase the max time the distributor is unavailable before promtail starts dropping logs to the range 51.1s - 81.2s.
Current setup:
Proposed change:
Which issue(s) this PR fixes:
Fixes #915
Special notes for your reviewer:
minbackoffguaranteed to be exponential (before it wasn't).Checklist