limits: limits implementation for loki #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
reviewed
Sep 9, 2019
slim-bean
reviewed
Sep 9, 2019
sandeepsukhani
force-pushed
the
limits
branch
from
7ee737e
to
4399cdc
Compare
Added following new limits: Length of query Number of active streams Number of streams matcher per query Ingestion rate
…nits for ingestion rate
sandeepsukhani
force-pushed
the
limits
branch
from
4e78e08
to
84ad5b3
Compare
2 tasks
rfratto
added a commit
to rfratto/loki
that referenced
this pull request
Nov 18, 2019
rfratto
added a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There were already some of the limits implemented in Loki.
Implemented new loki specific limits using latest Cortex which supports dynamic limits.
Added the following new limits:
Length of query
Number of active streams
Number of streams matcher per query
Ingestion rate
Checklist