Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logcli: added --step support to query command #1103

Merged

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Oct 2, 2019

What this PR does / why we need it:

Recently, logcli has been improved to also run range queries returning matrix (excellent!), but it lacks the --step support which I've introduced in this PR.

Checklist

  • Documentation added
  • Tests updated

cmd/logcli/main.go Outdated Show resolved Hide resolved
@pracucci pracucci force-pushed the add-step-support-to-logcli-query branch from 6997b88 to b9f030c Compare October 2, 2019 12:30
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 96237b5 into grafana:master Oct 2, 2019
@pracucci pracucci deleted the add-step-support-to-logcli-query branch October 3, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants