Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixins: Adds structured metadata panels #11087

Merged
merged 4 commits into from Nov 27, 2023
Merged

mixins: Adds structured metadata panels #11087

merged 4 commits into from Nov 27, 2023

Conversation

JoaoBraveCoding
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding commented Oct 30, 2023 •
edited

What this PR does / why we need it:

  1. Total received structured metadata per ingested data
  2. Total received structured metadata per tenant

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@JoaoBraveCoding
mixins: Adds two panels for structured metadata
f6d002d 
1. Total received structured metadata per ingested data
2. Total received structured metadata per tenant
@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review October 30, 2023 19:31
@JoaoBraveCoding JoaoBraveCoding requested a review from a team as a code owner October 30, 2023 19:31
salvacorts
salvacorts approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@salvacorts salvacorts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you :)

@salvacorts
Copy link
Contributor

@JoaoBraveCoding Can you rebase this PR with main?

@JoaoBraveCoding
Copy link
Contributor Author

@salvacorts done :)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited

Trivy scan found the following vulnerabilities:

@periklis periklis enabled auto-merge (squash) November 27, 2023 08:46
@periklis periklis merged commit bd505f8 into grafana:main Nov 27, 2023
7 checks passed
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Nov 28, 2023
@JoaoBraveCoding
Updates grafana/loki/production/loki-mixins jsonnet package
98ec454 
With this update we get:
- Reworked retention dashboards done in
  grafana#11263 as a follow-up to grafana#9884
- New write dashboards for structured metadata done in grafana#11087
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request Nov 28, 2023
Closed
8 tasks
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request Dec 13, 2023
Merged
8 tasks
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@JoaoBraveCoding @periklis @rhnasc
mixins: Adds structured metadata panels (grafana#11087)
d0caf6c 
Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salvacorts salvacorts salvacorts approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoaoBraveCoding @salvacorts @periklis