Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: Adds structured metadata dashboards #11330

Closed
wants to merge 12 commits into from
Closed

operator: Adds structured metadata dashboards #11330

wants to merge 12 commits into from

Conversation

JoaoBraveCoding
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding commented Nov 28, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes:
Issue: https://issues.redhat.com/browse/LOG-4700

Special notes for your reviewer:
Some of the retention dashboards are not working because I was using loki 2.9.2 and the new mixins are already for the next loki release.
image
image

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@JoaoBraveCoding
Updates grafana/loki/production/loki-mixins jsonnet package
98ec454 
With this update we get:
- Reworked retention dashboards done in
  grafana#11263 as a follow-up to grafana#9884
- New write dashboards for structured metadata done in grafana#11087
@github-actions GitHub Actions
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review November 28, 2023 10:57
@JoaoBraveCoding JoaoBraveCoding changed the title operator: Updates grafana/loki/production/loki-mixins jsonnet package operator: Adds structured metadata dashboards Dec 12, 2023
@periklis periklis enabled auto-merge (squash) December 12, 2023 09:53
auto-merge was automatically disabled December 12, 2023 09:53

Head branch was pushed to by a user without write access

@periklis periklis enabled auto-merge (squash) December 12, 2023 09:56
auto-merge was automatically disabled December 13, 2023 11:29

Head branch was pushed to by a user without write access

@JoaoBraveCoding
Copy link
Contributor Author

Closing in favor of #11473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

Assignees
No one assigned
Labels
sig/operator size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoaoBraveCoding @periklis