[bloom-compactor] Move meta.json creation at the end of compaction cycle #11234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trivy scan found the following vulnerabilities:
|
poyzannur
changed the title
poyzannur
changed the title
salvacorts
approved these changes
Nov 15, 2023
salvacorts
reviewed
Nov 15, 2023
| } | ||
|
|
||
| storedBlockRefs := make([]bloomshipper.BlockRef, len(storedBlocks)) |
There was a problem hiding this comment.
TODO: use pool for block refs and for tombstone refs. We should pass the storedBlocks buffer to CompactNewChunks to avoid allocations.
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…cle (grafana#11234) **What this PR does / why we need it**: This is a follow up from grafana#11115 Instead of a creating a meta file per bloom creation, create a meta file per compaction cycle. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a follow up from #11115
Instead of a creating a meta file per bloom creation, create a meta file per compaction cycle.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: