Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up golangci to 1.20 #1133

Merged
merged 4 commits into from
Oct 15, 2019
Merged

bump up golangci to 1.20 #1133

merged 4 commits into from
Oct 15, 2019

Conversation

daixiang0
Copy link
Contributor

Fix following warn:

+ make BUILD_IN_CONTAINER=false lint
GO111MODULE=on GOGC=10 golangci-lint run -j 4
level=warning msg="[runner/golint] Golint: can't lint 5 files: no file name for file &{Doc:<nil> Package:54184492 Name:main Decls:[0xc033cb7d40 0xc033cb7dc0 0xc03c4ccd50 0xc033cb7f40 0xc033cb7fc0 0xc033b9a000 0xc033b9a240 0xc03bde19b0] Scope:scope 0xc03bfe6ca0 {\n\tvar defaultClientCfg\n\ttype ConfigGetter\n\ttype format\n\tconst jsonFormat\n\tconst kvPairFormat\n\ttype config\n\tfunc parseConfig\n}\n Imports:[0xc03c4cc720 0xc03c4cc810 0xc03c4cc840 0xc03c4cc870 0xc03c4cc8a0 0xc03c4cc8d0 0xc03c4cc9c0 0xc03c4cc9f0 0xc03c4cca20 0xc03c4cca80 0xc03c4ccab0 0xc03c4ccba0 0xc03c4ccc00] Unresolved:[client flagext string string int iota client logging string string bool string error flagext nil nil errors strconv nil nil fmt time time strconv nil nil fmt logql nil nil make model model model lokiflag logging nil nil fmt strings strings false true nil fmt nil fmt ioutil nil nil fmt json nil nil fmt nil nil] Comments:[0xc0372bc660]}"

Details refer to issue, it is fixed in v1.20.

Signed-off-by: Xiang Dai 764524258@qq.com

Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

@joe-elliott mind help push a new image for this? i have no permission for it,

@joe-elliott
Copy link
Member

  • Build and pushed 0.7.3 with golangci-lint 1.20.0
  • Updated all references to the new image

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Copy link
Member

@rfratto @slim-bean

This PR is ready to go. Lint concurrency has been upped to 16 which is shaving ~30 seconds off of linting.

The one lint warning:

level=warning msg="[runner] Can't run linter goanalysis_metalinter: the_only_name: open /src/loki/pkg/logql/pkg/logql/expr.y: no such file or directory"

seems innocuous.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit b6faee2 into grafana:master Oct 15, 2019
@daixiang0 daixiang0 deleted the ci branch October 16, 2019 01:54
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Added retention feature to table manager to automatically remove olde…
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants