Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skips publishing images on PRs #12012

Closed
wants to merge 1 commit into from
Closed

skips publishing images on PRs #12012

wants to merge 1 commit into from

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Feb 20, 2024

We only need to publish images on main -- there's no need to publish PR builds and they can cause us to be rate limited much more easily, increase build times, etc.

@owen-d
skips publishing images on PRs
503c783 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner February 20, 2024 20:45
trevorwhitney
trevorwhitney requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owen-d how urgently do you need this? I've also removed this in #11808, as well as moving the checks over to GH actions. Can we wait on that to avoid merge conflicts?

@trevorwhitney
Copy link
Collaborator

Better yet, I can merge #11808 as soon as it's green and move any additional release pipeline work into a new PR

@trevorwhitney
Copy link
Collaborator

closing in favor or #11808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney requested changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owen-d @trevorwhitney