helm: update default terminationGracePeriodSeconds to 4800 #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users that run Loki using the Helm chart may not modify the value for terminationGracePeriodSeconds that allows Loki enough time to flush all of its data. If Loki is forcefully terminated by Kubernetes during a flush, missing data or an unhealthy ingester in the ring in microservices mode can occur. This commit changes the grace period to 4800 seconds, the value used in the Jsonnet code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users that run Loki using the Helm chart may not modify the value for terminationGracePeriodSeconds to allow Loki enough time to flush all of its data. If Loki is forcefully terminated by Kubernetes during a flush, missing data or an unhealthy ingester in the ring in microservices mode can occur.
This commit changes the grace period to 4800 seconds, the value used in the Jsonnet code.
I've never updated the Helm charts before so I'm not sure if I need to update the versions or do anything else (do I need to run a script somewhere?).
/cc @slim-bean