pkg/loki: unmarshal module name from YAML #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module name field in the config could not be unmarshalled from a string, causing parsing the config to crash. This commit also changes the error message when the config could not be parsed to print directly to stderr, as the logger won't be initialized at the point where parsing the config fails, leading to no output in the console. Fixes grafana#1259.
rfratto
force-pushed
the
unmarshal-module-name
branch
from
9a1a20c
to
89aa750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module name field in the config could not be unmarshalled from a string, causing parsing the config to crash.
This commit also changes the error message when the config could not be parsed to print directly to stderr, as the logger won't be initialized at the point where parsing the config fails, leading to no output in the console.
Fixes #1259.