Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when 'target' key is set in config.yaml #1259

Closed
eraac opened this issue Nov 13, 2019 · 1 comment · Fixed by #1260
Closed

crash when 'target' key is set in config.yaml #1259

eraac opened this issue Nov 13, 2019 · 1 comment · Fixed by #1260

Comments

@eraac
Copy link
Contributor

eraac commented Nov 13, 2019

Describe the bug
If I set target: "all" into config.yaml, loki crash instantly without log

To Reproduce
Steps to reproduce the behavior:

  1. Start Loki 0.4.0 with default configuration here
  2. No error
  3. Stop Loki
  4. Add target: "all" to config.yaml
  5. Start Loki 0.4.0 with updated config
  6. Crash without log (echo $? -> 1)

Expected behavior
No crash or log with information about the crash

Environment:

  • Infrastructure: ec2 instance
@rfratto rfratto mentioned this issue Nov 13, 2019
Merged
@rfratto
Copy link
Member

rfratto commented Nov 13, 2019 •
edited
Loading

Thanks for reporting! Until 0.5.0 is released with the fix from #1260, you'll have to not provide target into the config YAML. We've always passed the target as a flag, which is why we haven't noticed this yet:

loki -config.file=/path/to/file.yaml -target=all

rfratto added a commit to rfratto/loki that referenced this issue Nov 13, 2019
@rfratto
pkg/loki: unmarshal module name from YAML
89aa750 
The module name field in the config could not be unmarshalled from a
string, causing parsing the config to crash.

This commit also changes the error message when the config could not be
parsed to print directly to stderr, as the logger won't be initialized
at the point where parsing the config fails, leading to no output in the
console.

Fixes grafana#1259.
rfratto added a commit that referenced this issue Nov 13, 2019
@rfratto
pkg/loki: unmarshal module name from YAML (#1260)
a1901e2 
The module name field in the config could not be unmarshalled from a
string, causing parsing the config to crash.

This commit also changes the error message when the config could not be
parsed to print directly to stderr, as the logger won't be initialized
at the point where parsing the config fails, leading to no output in the
console.

Fixes #1259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/loki: unmarshal module name from YAML rfratto/loki
2 participants
@rfratto @eraac