Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k201] fix(blooms): Fix partitionSeriesByDay function #12901

Merged
merged 1 commit into from
May 6, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 738c274 from #12900


What this PR does / why we need it:

The function partitionSeriesByDay could yield empty when chunks were outside of the requested time range.

This would result in requests for a time range that does not contain any
chunks for a series to filter. These requests would return errors, because a subsequent partitionSeriesByDay for would remove that day resulting in no task.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

The function `partitionSeriesByDay` could yield empty when chunks were outside of the requested time range.

This would result in requests for a time range that does not contain any
chunks for a series to filter. These requests would return errors, because a subsequent `partitionSeriesByDay` for would remove that day resulting in no task.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit 738c274)
@grafanabot grafanabot requested a review from a team as a code owner May 6, 2024 14:27
@grafanabot grafanabot added backport size/M type/bug Somehing is not working as expected labels May 6, 2024
@grafanabot grafanabot requested a review from chaudum May 6, 2024 14:27
@chaudum chaudum merged commit fc2e1cd into k201 May 6, 2024
61 checks passed
@chaudum chaudum deleted the backport-12900-to-k201 branch May 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants