chore: download then extract in separate steps #13202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle error
chaudum
approved these changes
Jun 20, 2024
| @@ -22,6 +24,9 @@ func (m *mtxWithReadiness) markReady() { | |||
| } | |||
|
|
|||
| func (m *mtxWithReadiness) awaitReady(ctx context.Context) error { | |||
| ctx, cancel := context.WithTimeoutCause(ctx, 30*time.Second, errors.New("exceeded 30 seconds in awaitReady")) | |||
There was a problem hiding this comment.
The 30s timeout seems somewhat arbitrary, but it proved to be a reasonable value.
grafanabot
pushed a commit
that referenced
this pull request
Jun 21, 2024
This provides additional timing information about what step takes how long. Additionally, the `awaitReady()` function is gated with a timeout context to avoid overly long waiting times. Co-authored-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 28642b6)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle error
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR