Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [k207] chore: download then extract in separate steps #13279

Merged
merged 1 commit into from
Jun 21, 2024
Merged

chore: [k207] chore: download then extract in separate steps #13279

merged 1 commit into from
Jun 21, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 28642b6 from #13202

handle error

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean @grafana-delivery-bot
chore(index-gateway): Download then extract in separate steps (#13202)
a4fb070 
This provides additional timing information about what step takes how long.
Additionally, the `awaitReady()` function is gated with a timeout context to avoid overly long waiting times.

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit 28642b6)
@grafanabot grafanabot requested a review from a team as a code owner June 21, 2024 12:10
@grafanabot grafanabot requested a review from chaudum June 21, 2024 12:10
@slim-bean slim-bean merged commit af567fb into k207 Jun 21, 2024
61 checks passed
@slim-bean slim-bean deleted the backport-13202-to-k207 branch June 21, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

@chaudum chaudum Awaiting requested review from chaudum

Assignees
No one assigned
Labels
backport product-approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grafanabot @slim-bean