-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promtail Helm Chart: Add support for passing environment variables #1529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I see a problem in setting the env var, added a suggestion with a fix for it.
Some other suggestion regarding bumping up of version.
@cyriltovena I would appreciate your thoughts on this since I am fairly new to helm charts.
@cyriltovena please review |
You have conflicts, also why do you need env vars in promtails ? I don't think we support any env vars. |
Hi, @cyriltovena But I guess env vars support are really required feature |
* Make Promtail's Helm chart support passing extra env variables * bump charts versions
@cyriltovena We also had to pass environment variables to promtail to make it work in our environments. |
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
==========================================
- Coverage 61.84% 61.78% -0.07%
==========================================
Files 109 109
Lines 8304 8304
==========================================
- Hits 5136 5131 -5
- Misses 2774 2777 +3
- Partials 394 396 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This PR enables developers to pass environment variables to the
promtail
containers via helm similarly to how it's done for lokiWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist