Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This improves the log ouput for statistics in the logcli. #1644

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

I also only kept the summary as shown below :

logcli query --stats '{cluster="us-central1",container_name="promtail"} |= "foawdsda"' --since=12h
https://logs-dev-ops-tools1.grafana.net/loki/api/v1/query_range?direction=BACKWARD&end=1580934143741999000&limit=30&query=%7Bcluster%3D%22us-central1%22%2Ccontainer_name%3D%22promtail%22%7D+%7C%3D+%22foawdsda%22&start=1580890943741999000
Summary.BytesProcessedPerSeconds 	 425 MB
Summary.LinesProcessedPerSeconds 	 1424677
Summary.TotalBytesProcessed 		 44 GB
Summary.TotalLinesProcessed 		 147727595
Summary.ExecTime 			 1m43.691954136s

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #1644 into master will decrease coverage by 0.02%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
- Coverage    61.8%   61.77%   -0.03%     
==========================================
  Files         109      109              
  Lines        8308     8315       +7     
==========================================
+ Hits         5135     5137       +2     
- Misses       2780     2784       +4     
- Partials      393      394       +1
Impacted Files Coverage Δ
pkg/logcli/query/query.go 0% <0%> (ø) ⬆️
pkg/logql/stats/context.go 94.23% <100%> (+0.23%) ⬆️
pkg/logql/evaluator.go 91.75% <0%> (-1.04%) ⬇️

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up my mess

@cyriltovena cyriltovena merged commit 24d9956 into grafana:master Feb 13, 2020
billimek added a commit to billimek/loki that referenced this pull request Feb 13, 2020
* 'extraPorts' of github.com:billimek/loki: (25 commits)
  Ensure status codes are set correctly in the frontend. (grafana#1684)
  --dry-run Promtail. (grafana#1652)
  Fix logcli --quiet parameter parsing issue (grafana#1682)
  This improves the log ouput for statistics in the logcli. (grafana#1644)
  Loki stack helm chart can deploy datasources without Grafana (grafana#1688)
  Automatically prune metrics from the /metrics output of the promtail metrics pipeline stage after an idle period.
  Allow a metric defined as a counter to match all lines, useful for creating line count metrics which include all your labels. Found a bug in the the test runner where it didn't fail if the actual error was nil but the test expected an error Added some tests to the counters to test valid configs
  maintainer links & usernames (grafana#1675)
  Binary operators in LogQL (grafana#1662)
  Pipe data to Promtail (grafana#1649)
  Add Owen to the maintainer team. (grafana#1673)
  Update tanka.md so that promtail.yml is in the correct format (grafana#1671)
  Correcte syntax of rate example (grafana#1641)
  Frontend & Querier query statistics instrumentation. (grafana#1661)
  loki-canary: fix indent of DaemonSet manifest written in .md file (grafana#1648)
  Query frontend service should be headless. (grafana#1665)
  Support custom prefix name in metrics stage (grafana#1664)
  pkg/promtail/positions: handle empty positions file (grafana#1660)
  Convert second(Integer class) to nanosecond precision (grafana#1656)
  Unite docs for fluentd plugin (grafana#1634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants